Conversation
Pierre-Sassoulas
left a comment
Pierre-Sassoulas
left a comment
There was a problem hiding this comment.
I did not try to just vendor the missing deprecated function in prospector yet, did you think about it ?
|
When I saw the cleaning pull request, the missing function uses a lot of deprecated, then removed objects, then I didn't think that's easy to do! |
sbrunner
force-pushed
the
test-pylint-3.0-test
branch
from
f183dc8 to
bed9383
Compare
sbrunner
force-pushed
the
test-pylint-3.0-test
branch
2 times, most recently
from
86ff5ac to
5097b66
Compare
sbrunner
force-pushed
the
test-pylint-3.0-test
branch
2 times, most recently
from
17de0a4 to
971dc91
Compare
sbrunner
force-pushed
the
test-pylint-3.0-test
branch
from
971dc91 to
683f0b3
Compare
|
|
||
| found_files = _get_test_files("testpath", "testpath/test_useless_suppression.py") | ||
| pylint_tool.configure(config, found_files) | ||
| # useless-suppression is now disable by default in pylint |
There was a problem hiding this comment.
sbrunner
force-pushed
the
test-pylint-3.0-test
branch
from
683f0b3 to
359e573
Compare
|
@Pierre-Sassoulas @carlio Do you think that's ready to be merged? As I currently understand, if we want a better (more direct) implementation, we should do some modifications directly in PyLint! |
|
Thank you :-) Do we want something other in version 1.12 or do we do the release? |
|
I think it's best to release it now as people are waiting for a Python 3.12 compatible version; any other bugfixes or cleanups can go into a patch version. I am pretty sure the PyPI token secrets in the repo are still correct so the GitHub action can still be used to make the release, if you want to. |
|
You need to push a tag then create a github release from the tag to release on pypi @sbrunner (I could do it if you want, but it's a good thing if you already did it once imo) |
|
https://github.com/prospector-dev/prospector/blob/master/pyproject.toml#L3 <-- need to update that :) |
|
It's on release creation => Done :-) |
3 participants
Based on #671, fix some errors